Build a custom csb image with a (near) empty brokerpak#1
Merged
jameshochadel merged 1 commit intomainfrom Mar 22, 2024
Merged
Conversation
Instead of figuring out how to pull the brokerpaks into the cloud-service-broker docker build environment, this repo will build on top of that image with our customizations. Related to https://github.com/cloud-gov/product/issues/2943
markdboyd
reviewed
Mar 22, 2024
| @@ -0,0 +1,101 @@ | |||
| version: 1 | |||
Contributor
There was a problem hiding this comment.
Are we going to permanently leave this brokerpak in here?
Contributor
Author
There was a problem hiding this comment.
Nope, this is a test one to try to get the broker deploying. Real paks soon to come!
markdboyd
approved these changes
Mar 22, 2024
jameshochadel
added a commit
to cloud-gov/terraform-provision
that referenced
this pull request
Mar 22, 2024
Also sort alphabetically and add trailing comma to facilitate sorting Related to: cloud-gov/csb#1 https://github.com/cloud-gov/product/issues/2943
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Instead of figuring out how to pull the brokerpaks into the cloud-service-broker docker build environment, this repo will build on top of that image with our customizations.
Like all other images, this will be built by
common-pipelines. For future iteration, I'll work from a topic branch in this repo.Related to https://github.com/cloud-gov/product/issues/2943
Things to check
INFOand debugging statements are written withlog.debugor similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
None.